Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kotlin] protoc compiled code includes redundant public modifiers #9641

Closed
mscheong01 opened this issue Mar 17, 2022 · 0 comments · Fixed by #9642
Closed

[Kotlin] protoc compiled code includes redundant public modifiers #9641

mscheong01 opened this issue Mar 17, 2022 · 0 comments · Fixed by #9642
Labels
kotlin

Comments

@mscheong01
Copy link
Contributor

The new Protobuf support for Kotlin creates kotlin Dsl related classes, functions and objects which comes with a redundant 'public' modifier, which gives 'Redundant visibility modifier' IDE warnings
I thought that it would be nice to adopt the kotlin convention and remove them

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Kotlin] remove redundant public modifiers for compiled code mscheong01/protobuf
2 participants
@darly @mscheong01