use move method for SetString

reed-lau · acozzette · commit e4c7ead20c97 · 2019-08-09T16:04:05.000-07:00
diff --git a/python/google/protobuf/pyext/message.cc b/python/google/protobuf/pyext/message.cc
@@ -788,11 +788,11 @@ bool CheckAndSetString(
 
   string value_string(value, value_len);
   if (append) {
-    reflection->AddString(message, descriptor, value_string);
+    reflection->AddString(message, descriptor, std::move(value_string));
   } else if (index < 0) {
-    reflection->SetString(message, descriptor, value_string);
+    reflection->SetString(message, descriptor, std::move(value_string));
   } else {
-    reflection->SetRepeatedString(message, descriptor, index, value_string);
+    reflection->SetRepeatedString(message, descriptor, index, std::move(value_string));
   }
   return true;
 }

Original file line number	Diff line number	Diff line change
`@@ -788,11 +788,11 @@ bool CheckAndSetString(`
`788`	`788`
`789`	`789`	`string value_string(value, value_len);`
`790`	`790`	`if (append) {`
`791`		`- reflection->AddString(message, descriptor, value_string);`
	`791`	`+ reflection->AddString(message, descriptor, std::move(value_string));`
`792`	`792`	`} else if (index < 0) {`
`793`		`- reflection->SetString(message, descriptor, value_string);`
	`793`	`+ reflection->SetString(message, descriptor, std::move(value_string));`
`794`	`794`	`} else {`
`795`		`- reflection->SetRepeatedString(message, descriptor, index, value_string);`
	`795`	`+ reflection->SetRepeatedString(message, descriptor, index, std::move(value_string));`
`796`	`796`	`}`
`797`	`797`	`return true;`
`798`	`798`	`}`