From 8c6e5b79636673435c9a8afe51dd2ffe4a2c7f4b Mon Sep 17 00:00:00 2001 From: Mark Hansen Date: Fri, 10 May 2024 08:29:52 -0700 Subject: [PATCH] Avoid allocating iterator in TextFormat printing UnknownFieldSet PiperOrigin-RevId: 632503842 --- java/core/src/main/java/com/google/protobuf/TextFormat.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/java/core/src/main/java/com/google/protobuf/TextFormat.java b/java/core/src/main/java/com/google/protobuf/TextFormat.java index eb05fb2f41f07..71b2b33f674cc 100644 --- a/java/core/src/main/java/com/google/protobuf/TextFormat.java +++ b/java/core/src/main/java/com/google/protobuf/TextFormat.java @@ -581,6 +581,9 @@ private void printSingleField( private static void printUnknownFields( final UnknownFieldSet unknownFields, final TextGenerator generator) throws IOException { + if (unknownFields.isEmpty()) { + return; + } for (Map.Entry entry : unknownFields.asMap().entrySet()) { final int number = entry.getKey(); final UnknownFieldSet.Field field = entry.getValue();