You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Typings for IMethod defines a field comment to be string, but comment is understandably undefined when there is no comment. I think this is supposed to be nullable as all other interfaces define the field comment as.
As far as i can tell, the following line 677 should be comment: (string|null) as all other comment fields are. Or even better, comment?: string.
I could create a pull request if this is correct :)
protobuf.js version: 7.1.2
Typings for
IMethod
defines a fieldcomment
to bestring
, butcomment
is understandably undefined when there is no comment. I think this is supposed to be nullable as all other interfaces define the fieldcomment
as.As far as i can tell, the following line 677 should be
comment: (string|null)
as all other comment fields are. Or even better,comment?: string
.I could create a pull request if this is correct :)
protobuf.js/index.d.ts
Lines 656 to 681 in d026849
The missing comment field is displayed in this sample
The text was updated successfully, but these errors were encountered: