Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM-issue: version 7.1.1 is the same as 7.1.0 #1805

Open
basgroot opened this issue Sep 11, 2022 · 3 comments
Open

NPM-issue: version 7.1.1 is the same as 7.1.0 #1805

basgroot opened this issue Sep 11, 2022 · 3 comments

Comments

@basgroot
Copy link
Contributor

protobuf.js version: 7.1.1

The patch version 7.1.1 doesn't seem to differ from 7.1.0. Only the compile date is updated.

Steps

  1. Install latest version with 'npm install protobufjs'
  2. Examine the file \node_modules\protobufjs\dist\protobuf.js

Expected

  • The header of protobuf.js shows the latest version 7.1.1.
  • The patch of 7.1.1 is included (var defaultAlreadyEmitted).

Actual
The header shows 7.1.0. Only the compile date was updated.
The patch (var defaultAlreadyEmitted) is not included. Code is identical to 7.1.0.

Both CDNs demonstrate the issue as well:
https://cdn.jsdelivr.net/npm/[email protected]/dist/protobuf.js
https://unpkg.com/[email protected]/dist/protobuf.js

Older versions seem to have the issue too:
https://unpkg.com/[email protected]/dist/protobuf.js vs https://unpkg.com/[email protected]/dist/protobuf.js

Workaround
Generate the dist folder manually, with command: 'npm run build'

But CDN support is not available when doing this.

@basgroot
Copy link
Contributor Author

The JSDoc/comment changes of 7.1.2 ARE available in https://cdn.jsdelivr.net/npm/[email protected]/dist/protobuf.js:
image

@basgroot
Copy link
Contributor Author

basgroot commented Feb 4, 2023

This issue can be closed, because it doesn't reproduce in 7.2.0 vs 7.2.1.

@basgroot basgroot closed this as completed Feb 4, 2023
@basgroot
Copy link
Contributor Author

basgroot commented Feb 7, 2023

Need to reopen this again. Version https://cdn.jsdelivr.net/npm/[email protected]/dist/protobuf.js downloads version 7.1.0.

image

image

@basgroot basgroot reopened this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant