Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fake webserver with Avalanche #559

Closed
saketjajoo opened this issue Jun 16, 2023 · 4 comments
Closed

Replace fake webserver with Avalanche #559

saketjajoo opened this issue Jun 16, 2023 · 4 comments

Comments

@saketjajoo
Copy link
Contributor

saketjajoo commented Jun 16, 2023

Currently, the setup uses fake webserver as the metrics emitter which only supports standard metrics (e.g. the debug/* metrics and the process and go metrics). Having variable/configurable metrics would help collect good benchmarking data. Hence, I suggest replacing the fake webserver component with avalanche.

Avalanche provides several configurable options to change the configurations (e.g. metrics count, label count, series count, metric name length, etc.). Although, this may not represent production-like metrics (for e.g. metric names are like avalanche_metric_mmmmm_01 does not look like a real workload metric), having different configurations can help collect good data to benchmark and analyze the Prometheus's performance.


Sample / Reference Commit: https://github.com/saketjajoo/test-infra/commit/eb8678bdfa2f5404bbf3997103f20cfb18ca6877

@bwplotka
Copy link
Member

This is still relevant, especially after the latest changes in 0.6.0 prometheus-community/avalanche#101

@bwplotka
Copy link
Member

Did a quick research around swapping fake-webserver with avalanche.

I think I would propose we keep fake-webserver. We could simplify it a bit and move to avalanche project as another mode to improve maintainability.

WDYT @ArthurSens @bboreham @kakkoyun

Closing for now, we can reopen.

@ArthurSens
Copy link
Member

I think we'll need avalanche to Benchmark CTs, but agree this can be done in a custom benchmark

@bwplotka
Copy link
Member

We can (and should) add native histograms and CTs to fake-webserver IMO (pull the latest client and configure nhs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants