Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add group key to alert groups endpoint #3446

Open
Spaceman1701 opened this issue Aug 7, 2023 · 2 comments
Open

Re-add group key to alert groups endpoint #3446

Spaceman1701 opened this issue Aug 7, 2023 · 2 comments

Comments

@Spaceman1701
Copy link
Contributor

I'm working on some integrations which would benefit from associating webhook notifications with alerts returned from the results from alerts/groups. It'd be super useful if this endpoint included the group key for each group.

It looks like the old v1 api did include the group key in AlertGroup (#576) but when the new v2 api was added this field was omitted: #1791

There doesn't seem to be any discussion of the group key in #1791 so my guess is that it was just an accidental removal. Are there any concerns about re-adding this?

@simonpasquier
Copy link
Member

I participated in the discussions you've mentioned but can't remember if the choice of not including the group key was deliberate or not 🤔
I've got no strong objection of adding the information but I'd like to hear from @gotjosh too.

@fihufil
Copy link

fihufil commented May 29, 2024

Hello everyone!

Reintroduction of this feature would be really welcome as it would allow us to do some more automation around Alertmanager, is it possible to reconsider this PR?

KR,
Filip Dorosz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants