From cadc3b19c95dbae105400a80ea0dedc96b99945e Mon Sep 17 00:00:00 2001
From: mgianluc <mgianluca@cisco.com>
Date: Wed, 14 Jun 2023 15:48:54 +0200
Subject: [PATCH] Fix lint

---
 controllers/handlers_kustomize.go |  9 +++++++--
 controllers/handlers_utils.go     | 14 ++++++--------
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/controllers/handlers_kustomize.go b/controllers/handlers_kustomize.go
index 655bfda6..513cb903 100644
--- a/controllers/handlers_kustomize.go
+++ b/controllers/handlers_kustomize.go
@@ -504,7 +504,7 @@ func deployKustomizeResources(ctx context.Context, c client.Client, remoteRestCo
 		Name:      kustomizationRef.Name,
 	}
 
-	localReports, err = deployUnstructured(ctx, true, localConfig, c, objectsToDeployLocally,
+	localReports, err = deployUnstructured(ctx, localConfig, c, objectsToDeployLocally,
 		ref, configv1alpha1.FeatureKustomize, clusterSummary, logger)
 	if err != nil {
 		logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to deploy to management cluster %v", err))
@@ -516,7 +516,12 @@ func deployKustomizeResources(ctx context.Context, c client.Client, remoteRestCo
 		return nil, nil, err
 	}
 
-	remoteReports, err = deployUnstructured(ctx, false, remoteRestConfig, remoteClient, objectsToDeployRemotely,
+	err = validateUnstructred(ctx, true, objectsToDeployRemotely, clusterSummary, logger)
+	if err != nil {
+		return nil, nil, err
+	}
+
+	remoteReports, err = deployUnstructured(ctx, remoteRestConfig, remoteClient, objectsToDeployRemotely,
 		ref, configv1alpha1.FeatureKustomize, clusterSummary, logger)
 	if err != nil {
 		logger.V(logs.LogInfo).Info(fmt.Sprintf("failed to deploy to remote cluster %v", err))
diff --git a/controllers/handlers_utils.go b/controllers/handlers_utils.go
index e473077a..debb26d6 100644
--- a/controllers/handlers_utils.go
+++ b/controllers/handlers_utils.go
@@ -185,20 +185,18 @@ func deployContent(ctx context.Context, deployingToMgmtCluster bool, destConfig
 		Name:      referencedObject.GetName(),
 	}
 
-	err = validateUnstructred(ctx, deployingToMgmtCluster, destConfig, destClient, referencedUnstructured, ref,
-		configv1alpha1.FeatureResources, clusterSummary, logger)
+	err = validateUnstructred(ctx, deployingToMgmtCluster, referencedUnstructured, clusterSummary, logger)
 	if err != nil {
 		return nil, err
 	}
 
-	return deployUnstructured(ctx, deployingToMgmtCluster, destConfig, destClient, referencedUnstructured, ref,
+	return deployUnstructured(ctx, destConfig, destClient, referencedUnstructured, ref,
 		configv1alpha1.FeatureResources, clusterSummary, logger)
 }
 
-func validateUnstructred(ctx context.Context, deployingToMgmtCluster bool, destConfig *rest.Config,
-	destClient client.Client, referencedUnstructured []*unstructured.Unstructured, referencedObject *corev1.ObjectReference,
-	featureID configv1alpha1.FeatureID, clusterSummary *configv1alpha1.ClusterSummary, logger logr.Logger,
-) error {
+func validateUnstructred(ctx context.Context, deployingToMgmtCluster bool,
+	referencedUnstructured []*unstructured.Unstructured, clusterSummary *configv1alpha1.ClusterSummary,
+	logger logr.Logger) error {
 
 	for i := range referencedUnstructured {
 		policy := referencedUnstructured[i]
@@ -228,7 +226,7 @@ func validateUnstructred(ctx context.Context, deployingToMgmtCluster bool, destC
 // Returns an error if one occurred. Otherwise it returns a slice containing the name of
 // the policies deployed in the form of kind.group:namespace:name for namespaced policies
 // and kind.group::name for cluster wide policies.
-func deployUnstructured(ctx context.Context, deployingToMgmtCluster bool, destConfig *rest.Config,
+func deployUnstructured(ctx context.Context, destConfig *rest.Config,
 	destClient client.Client, referencedUnstructured []*unstructured.Unstructured, referencedObject *corev1.ObjectReference,
 	featureID configv1alpha1.FeatureID, clusterSummary *configv1alpha1.ClusterSummary, logger logr.Logger,
 ) (reports []configv1alpha1.ResourceReport, err error) {