From e34c73ca00aa18d294267bc0a70527693185771b Mon Sep 17 00:00:00 2001 From: Vadim Shvetsov Date: Tue, 27 Apr 2021 12:06:17 +0300 Subject: [PATCH 1/2] fix: Check if port exist before checking reportPosition --- .../react-diagrams-core/src/entities/link/LinkModel.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-diagrams-core/src/entities/link/LinkModel.ts b/packages/react-diagrams-core/src/entities/link/LinkModel.ts index c81f71bc6..f74cfcdee 100644 --- a/packages/react-diagrams-core/src/entities/link/LinkModel.ts +++ b/packages/react-diagrams-core/src/entities/link/LinkModel.ts @@ -215,7 +215,7 @@ export class LinkModel return this.points[this.points.length - 1]; } - setSourcePort(port: PortModel) { + setSourcePort(port: PortModel | null) { if (port !== null) { port.addLink(this); } @@ -224,7 +224,7 @@ export class LinkModel } this.sourcePort = port; this.fireEvent({ port }, 'sourcePortChanged'); - if (port.reportedPosition) { + if (port?.reportedPosition) { this.getPointForPort(port).setPosition(port.getCenter()); } } @@ -237,7 +237,7 @@ export class LinkModel return this.targetPort; } - setTargetPort(port: PortModel) { + setTargetPort(port: PortModel | null) { if (port !== null) { port.addLink(this); } @@ -246,7 +246,7 @@ export class LinkModel } this.targetPort = port; this.fireEvent({ port }, 'targetPortChanged'); - if (port.reportedPosition) { + if (port?.reportedPosition) { this.getPointForPort(port).setPosition(port.getCenter()); } } From 63a41c634f8ab7077c6898c4ecc36cff3e75b2bc Mon Sep 17 00:00:00 2001 From: Vadim Shvetsov Date: Tue, 27 Apr 2021 12:12:21 +0300 Subject: [PATCH 2/2] fix(CI): Fix Pathfinding import at CI --- packages/react-diagrams-routing/tests/PathFinding.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-diagrams-routing/tests/PathFinding.test.tsx b/packages/react-diagrams-routing/tests/PathFinding.test.tsx index c3dbc874f..53b78d08e 100644 --- a/packages/react-diagrams-routing/tests/PathFinding.test.tsx +++ b/packages/react-diagrams-routing/tests/PathFinding.test.tsx @@ -1,4 +1,4 @@ -import PathFinding from '../src/engine/PathFinding'; +import { PathFinding } from '../src/engine/PathFinding'; describe('calculating start and end points', function () { beforeEach(() => {