From ff2a668842009828a769c475fae245b72e991f0c Mon Sep 17 00:00:00 2001 From: Steve Ruble Date: Thu, 23 Apr 2020 17:16:08 -0400 Subject: [PATCH] Support deriving from DefaultLabelModel The DefaultLabelModel constructor deviated from pattern followed by the other Default*Model types, where `...options` is merged after the hardcoded values so that derived classes can override the options. This change makes it conform to that pattern. --- .../react-diagrams-defaults/src/label/DefaultLabelModel.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-diagrams-defaults/src/label/DefaultLabelModel.tsx b/packages/react-diagrams-defaults/src/label/DefaultLabelModel.tsx index e6230496..3bfaf1ff 100644 --- a/packages/react-diagrams-defaults/src/label/DefaultLabelModel.tsx +++ b/packages/react-diagrams-defaults/src/label/DefaultLabelModel.tsx @@ -12,9 +12,9 @@ export interface DefaultLabelModelGenerics extends LabelModelGenerics { export class DefaultLabelModel extends LabelModel { constructor(options: DefaultLabelModelOptions = {}) { super({ - ...options, offsetY: options.offsetY == null ? -23 : options.offsetY, - type: 'default' + type: 'default', + ...options }); }