From 4fd919f5209dd04fd1684cdcb1c7ca1774981874 Mon Sep 17 00:00:00 2001 From: Satyam Lal Date: Thu, 2 Jan 2025 17:54:39 +0530 Subject: [PATCH 1/2] Fix batch_run data collection on final step --- mesa/batchrunner.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/mesa/batchrunner.py b/mesa/batchrunner.py index bcc4dffb164..40aeb082a9e 100644 --- a/mesa/batchrunner.py +++ b/mesa/batchrunner.py @@ -173,9 +173,12 @@ def _model_run_func( data = [] + # steps for data collection steps = list(range(0, model.steps, data_collection_period)) - if not steps or steps[-1] != model.steps - 1: - steps.append(model.steps - 1) + + # final step for data collection + if steps and steps[-1] != model.steps: + steps.append(model.steps) for step in steps: model_data, all_agents_data = _collect_data(model, step) From 3382e63db85212dd4ac15504352d6480e806e921 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 2 Jan 2025 12:48:35 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- mesa/batchrunner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mesa/batchrunner.py b/mesa/batchrunner.py index 40aeb082a9e..ec80f98952b 100644 --- a/mesa/batchrunner.py +++ b/mesa/batchrunner.py @@ -175,7 +175,7 @@ def _model_run_func( # steps for data collection steps = list(range(0, model.steps, data_collection_period)) - + # final step for data collection if steps and steps[-1] != model.steps: steps.append(model.steps)