Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add global OS_MAX_THREADS env variable #571

Closed
dogancanbakir opened this issue Nov 26, 2024 · 0 comments · Fixed by #572
Closed

add global OS_MAX_THREADS env variable #571

dogancanbakir opened this issue Nov 26, 2024 · 0 comments · Fixed by #572
Assignees
@dogancanbakir
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@dogancanbakir
Copy link
Member 

          Since this is something valid for all the tools I think we should consider overidding the setting via environment variable and move this logic to the utils package that will evaluate within an `init()` function in any existing package providing similar functionalities, or eventually creating a new one named `global`, for example:

$ OS_THREADS=xxx nuclei

What do you think?

Originally posted by @Mzack9999 in projectdiscovery/nuclei#5622 (review)
@dogancanbakir dogancanbakir changed the title Since this is something valid for all the tools I think we should consider overidding the setting via environment variable and move this logic to the utils package that will evaluate within an init() function in any existing package providing similar functionalities, or eventually creating a new one named global, for example: add global OS_MAX_THREADS env variable Nov 26, 2024
@dogancanbakir dogancanbakir self-assigned this Nov 26, 2024
@dogancanbakir dogancanbakir mentioned this issue Nov 26, 2024
Merged
@Mzack9999 Mzack9999 added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dogancanbakir dogancanbakir

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add global OS_MAX_THREADS env variable projectdiscovery/utils
2 participants
@Mzack9999 @dogancanbakir