Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Nuclei Engine 'GetTemplates' ignores templatesLoaded and always re-load all templates #5726

Closed
1 task done
BarVaserman opened this issue Oct 13, 2024 · 0 comments · Fixed by #5733
Closed
1 task done
Assignees
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@BarVaserman
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Current Behavior

Ref -

func (e *NucleiEngine) GetTemplates() []*templates.Template {

GetTemplates check it against e.templatesLoaded, but it never being changed to true after successfully loading it,
so every-time someone asks for the templates, he actually load them again and maybe even manipulate them without knowing what was the previous state.

Expected Behavior

Not loading them again

Steps To Reproduce

engine.LoadTargets([]string{targetUrl}, false)
engine.ExecuteWithCallback(callback)
engine.GetTemplates()

Relevant log output

No response

Environment

  • OS: Macos
  • Nuclei: v3.3.2
  • Go: go1.23.0

Anything else?

No response

@BarVaserman BarVaserman added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 13, 2024
@dogancanbakir dogancanbakir self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants