From f678967037af3e344697516e880444bab0595772 Mon Sep 17 00:00:00 2001 From: Steve Sloka Date: Sun, 21 Feb 2021 20:19:58 -0500 Subject: [PATCH] ci: Add missing linters to CI runs (#3379) The CI job was missing the `yamllint` & `flags` tasks to verify the yaml format as well as flags. This adds those back in as well as fixes the one issue found with the comment on the ratelimit example. Signed-off-by: Steve Sloka --- .github/workflows/prbuild.yaml | 2 +- examples/ratelimit/02-ratelimit.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/prbuild.yaml b/.github/workflows/prbuild.yaml index a2c614987d0..632fec0c23b 100644 --- a/.github/workflows/prbuild.yaml +++ b/.github/workflows/prbuild.yaml @@ -86,5 +86,5 @@ jobs: go-version: '1.15.8' - name: generate run: | - make generate + make generate lint-yamllint lint-flags ./hack/actions/check-uncommitted-codegen.sh diff --git a/examples/ratelimit/02-ratelimit.yaml b/examples/ratelimit/02-ratelimit.yaml index a49da5896ff..4fd43b0f801 100644 --- a/examples/ratelimit/02-ratelimit.yaml +++ b/examples/ratelimit/02-ratelimit.yaml @@ -44,7 +44,7 @@ spec: - name: REDIS_URL value: redis:6379 - name: ratelimit - image: docker.io/envoyproxy/ratelimit:6f5de117 # latest a/o Jan 22 2021 + image: docker.io/envoyproxy/ratelimit:6f5de117 # latest a/o Jan 22 2021 ports: - containerPort: 8080 name: http