2 generated migrations do not include Rails version number

[camillevilla]

Rails version numbers are not getting appended to two generated ActiveRecord migrations. Users creating new apps get the following error after running rake db:migrate:

rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

Directly inheriting from ActiveRecord::Migration is not supported. Please specify the Rails release the migration was written for:

  class CreateFriendlyIdSlugs < ActiveRecord::Migration[4.2]
/Users/cvilla/scratchpad/app-name/db/migrate/20180112215454_create_friendly_id_slugs.rb:1:in `<top (required)>'

What we get:

class CreateFriendlyIdSlugs < ActiveRecord::Migration

What we want:

class CreateFriendlyIdSlugs < ActiveRecord::Migration[4.2]

Migrations to be fixed:

• _create_friendly_id_slugs.rb
• _devise_invitable_add_to_users.rb

Notes:

• Why are Travis builds still passing?
• This error has been happening since November 7, 2017 (Migration fails during installation, cannot get forward #1859)

Manual fixes:

See discussion in #1877

[jkeck]

I wonder if this is a problem w/ friendly_id norman/friendly_id#817

[mjgiarlo]

Looks like a bunch of PRs to address this are waiting in friendly_id: https://github.com/norman/friendly_id/pulls This does not inspire confidence that it'll be addressed.

(FWIW, we have a solution for this in Hyrax that was based on the solution in Devise: samvera/hyrax#2361 -- I don't think this helps Spotlight, necessarily...)