Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework support missing #278

Open
tomasz-czyzak opened this issue May 16, 2017 · 2 comments
Open

Framework support missing #278

tomasz-czyzak opened this issue May 16, 2017 · 2 comments

Comments

@tomasz-czyzak
Copy link
Contributor

There is an issue when your database is delivered thru framework.
During migration method:
- (BOOL)loadMetadata:(NSError **)error {
calls:
[bundles addObject:[NSBundle mainBundle]];
as a result it can't find model delivered in framework bundle and migration fails.
It should use:
[[NSBundle bundleForClass:[self class]]
or
[NSBundle bundleWithIdentifier:modelBundleIdentifier];
where modelBundleIdentifier is being passed from application thru options dictionary

@lolgear
Copy link
Contributor

lolgear commented Jun 20, 2017

@tomasz-czyzak does PR #268 fix it?

@tomasz-czyzak
Copy link
Contributor Author

Looks ok however I didn't check it. This solution is based on passing whole bundle during init.
While my private fix is based on passing only bundle id in options.
Here is my private fix: #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants