Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't support advertising multiple operational identities #8438

Closed
bzbarsky-apple opened this issue Jul 15, 2021 · 3 comments
Closed

We don't support advertising multiple operational identities #8438

bzbarsky-apple opened this issue Jul 15, 2021 · 3 comments
Labels
maybe done? Isssue may be complete/obsolete/not relevant anymore. Needs review to determine if to close or not. spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

Both DiscoveryImplPlatform::Advertise(const OperationalAdvertisingParameters & params) and AdvertiserMinMdns::Advertise(const OperationalAdvertisingParameters & params) override an existing advertisement if there is one. This makes it impossible to advertise multiple operational identities.

Proposed Solution

Fix both codepaths to support multiple operational ids.

See also #8037 and #6141

@andy31415 @cecille @pan-apple

@stale
Copy link

stale bot commented Jan 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jan 26, 2022
@stale stale bot removed the stale Stale issue or PR label Jan 26, 2022
@woody-apple woody-apple added spec Mismatch between spec and implementation and removed v1_secondary_triage labels Feb 1, 2022
@bzbarsky-apple
Copy link
Contributor Author

I believe this is fixed now. AdvertiserMinMdns::Advertise does:

    auto * operationalAllocator = FindOperationalAllocator(nameCheck);

which will use different allocators for different instance names (which are different per operational identity). I don't see anything obvious in DiscoveryImplPlatform::Advertise that would preclude multiple operational identities (though some platform impls could have their own constraints, I suppose).

@vivien-apple @andy31415 can you confirm?

@bzbarsky-apple bzbarsky-apple added the maybe done? Isssue may be complete/obsolete/not relevant anymore. Needs review to determine if to close or not. label May 4, 2022
@andy31415
Copy link
Contributor

As far as I am aware, we are able to advertise multiple operational networks and we are able to do operational discovery for specific identities. Multi-admin tests validate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe done? Isssue may be complete/obsolete/not relevant anymore. Needs review to determine if to close or not. spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

No branches or pull requests

4 participants