You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a continuation of the work described in #2168 that is not finished yet.
We now have an buffer reader class, but none of the rest of the work has happened. In particular, we need to replace use of emberAfGet* with the buffer reader, possibly replace emberAfPut*InResp with some sort of sematic writer, etc.
Switch all the places to-be-read buffers are passed through (command dispatch, command implementations as needed, etc) to our buffer reader. This would include the emberAfGet* APIs, which would be fixed to advance the read pointer themselves so consumers don't have to.
Introduce Put APIs for higher-level constructs like "attribute id", not just integer sizes. Under the hood this can call the appropriate integer thing, but make it clearer what we're really reading/writing. Basically, create a writer on top of BufBound that has semantic stuff hanging off it.
We can't fully fix this until we change codegen to ZAP. I will probably be filing separate issues for parts of the above work in src/app.
Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.91. Please mark this comment with 👍 or 👎 to give our bot feedback!
Problem
This is a continuation of the work described in #2168 that is not finished yet.
We now have an buffer reader class, but none of the rest of the work has happened. In particular, we need to replace use of
emberAfGet*
with the buffer reader, possibly replaceemberAfPut*InResp
with some sort of sematic writer, etc.Proposed Solution
Copying from #2168, more or less:
emberAfGet*
APIs, which would be fixed to advance the read pointer themselves so consumers don't have to.Put
APIs for higher-level constructs like "attribute id", not just integer sizes. Under the hood this can call the appropriate integer thing, but make it clearer what we're really reading/writing. Basically, create a writer on top ofBufBound
that has semantic stuff hanging off it.We can't fully fix this until we change codegen to ZAP. I will probably be filing separate issues for parts of the above work in
src/app
.@yunhanw-google @vivien-apple @rwalker-apple
The text was updated successfully, but these errors were encountered: