Follow up review comments for cleaning up code and handling the start timer error and other errors in the OTA provider delegate code for darwin

[nivi-apple]

Member
@andy31415 andy31415 31 minutes ago
Also were is the caller code mapping this to BDX errors? Can't it have the INCORRECT_STATE as a default or is there some other default?

I guess documentation then has to say that this method MUST always return a subset of errors. Is that documented?

Member
@andy31415 andy31415 30 minutes ago
and going further ... if the caller needs a BDX state not a chip error (i.e. it has to map) ... why does this function return a CHIP_ERROR at all?

Member
@bzbarsky-apple bzbarsky-apple 12 minutes ago
There's a lot of general logic cleanup that should happen here, but we are trying to avoid scope creep... Will do that in a followup.