-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling between BindingManager::EstablishConnection and BindingManager::HandleDeviceConnectionFailure less then ideal #22173
Comments
BindingManager initially was created around a totally different setup in terms of session lifetimes than we have now... that is part of the problem for sure. |
For any future reference to either myself or anyone else working on this bug, this is only one section that would need to be better thought out: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This stale issue has been automatically closed. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Problem
BindingManager
seems like it is expecting different behaviors fromCASESessionManager
, or that CASESessionManager has evolved way beyond what BindingManager was initially expecting it to do. As a result the error handling betweenBindingManager::EstablishConnection
andBindingManager::HandleDeviceConnectionFailure
is no longer adequate. Seeing that 1.0 release is soon and we are only taking in changes that are more critical, this was not fixed and instead is documented here as a post 1.0 issue.The text was updated successfully, but these errors were encountered: