Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling between BindingManager::EstablishConnection and BindingManager::HandleDeviceConnectionFailure less then ideal #22173

Open
tehampson opened this issue Aug 25, 2022 · 5 comments
Assignees

Comments

@tehampson
Copy link
Contributor

Problem

  • Error handling in BindingManager seems like it is expecting different behaviors from CASESessionManager, or that CASESessionManager has evolved way beyond what BindingManager was initially expecting it to do. As a result the error handling between BindingManager::EstablishConnection and BindingManager::HandleDeviceConnectionFailure is no longer adequate. Seeing that 1.0 release is soon and we are only taking in changes that are more critical, this was not fixed and instead is documented here as a post 1.0 issue.
@bzbarsky-apple
Copy link
Contributor

BindingManager initially was created around a totally different setup in terms of session lifetimes than we have now... that is part of the problem for sure.

@tehampson tehampson self-assigned this Sep 12, 2022
@tehampson
Copy link
Contributor Author

For any future reference to either myself or anyone else working on this bug, this is only one section that would need to be better thought out:

@stale
Copy link

stale bot commented Mar 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Mar 19, 2023
@stale
Copy link

stale bot commented Apr 2, 2023

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Apr 2, 2023
@bzbarsky-apple bzbarsky-apple reopened this Apr 3, 2023
@stale stale bot removed the stale Stale issue or PR label Apr 3, 2023
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 15, 2023
@tehampson tehampson removed the stale Stale issue or PR label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants