Remove WriteRemainingDuration as it violates spec by allowing writes …

…to a read-only atribute
project-chip · Jan 30, 2025 · a020d68 · a020d68
1 parent 57e936d
commit a020d68
Showing 1 changed file with 0 additions and 35 deletions.
diff --git a/...lusters/valve-configuration-and-control-server/valve-configuration-and-control-server.cpp b/...lusters/valve-configuration-and-control-server/valve-configuration-and-control-server.cpp
@@ -101,11 +101,9 @@ class ValveConfigAndControlAttrAccess : public AttributeAccessInterface
     {}
 
     CHIP_ERROR Read(const ConcreteReadAttributePath & aPath, AttributeValueEncoder & aEncoder) override;
-    CHIP_ERROR Write(const ConcreteDataAttributePath & aPath, AttributeValueDecoder & aDecoder);
 
 private:
     CHIP_ERROR ReadRemainingDuration(EndpointId endpoint, AttributeValueEncoder & aEncoder);
-    CHIP_ERROR WriteRemainingDuration(EndpointId endpoint, AttributeValueDecoder & aDecoder);
 };
 
 ValveConfigAndControlAttrAccess gAttrAccess;
@@ -140,39 +138,6 @@ CHIP_ERROR ValveConfigAndControlAttrAccess::Read(const ConcreteReadAttributePath
 
     return err;
 }
-
-CHIP_ERROR ValveConfigAndControlAttrAccess::WriteRemainingDuration(EndpointId endpoint, AttributeValueDecoder & aDecoder)
-{
-    DataModel::Nullable<uint32_t> rDuration;
-    CHIP_ERROR res = aDecoder.Decode(rDuration);
-    if (res != CHIP_NO_ERROR)
-        return res;
-    if (rDuration.IsNull() || NumericAttributeTraits<uint32_t>::IsNullValue(rDuration.Value()))
-        return ValveConfigurationAndControl::SetRemainingDurationNull(endpoint);
-    else
-        return ValveConfigurationAndControl::SetRemainingDuration(endpoint, rDuration);
-}
-
-CHIP_ERROR ValveConfigAndControlAttrAccess::Write(const ConcreteDataAttributePath & aPath, AttributeValueDecoder & aDecoder)
-{
-    if (aPath.mClusterId != ValveConfigurationAndControl::Id)
-    {
-        return CHIP_ERROR_INVALID_PATH_LIST;
-    }
-
-    switch (aPath.mAttributeId)
-    {
-    case RemainingDuration::Id: {
-        return WriteRemainingDuration(aPath.mEndpointId, aDecoder);
-    }
-    default: {
-        break;
-    }
-    }
-
-    return CHIP_NO_ERROR;
-}
-
 } // namespace
 
 static void startRemainingDurationTick(EndpointId ep);