Source maps shouldn't be required

[turboMaCk]

Ahoj kluci!

I ran into issue while trying out this plugin. It seems like source maps are required by this task.

This doesn't seem right since not every compiler has support for source map generation.

This is full log:

$ ./node_modules/.bin/deploy staging                                                                                                                                                                                                           
Environment: ▇▇▇▇▇▇
Deploying branch ▇▇▇▇▇▇

Detected 1 build app versions:
        bfb▇▇▇▇▇▇▇▇▇▇▇▇: log

[21:43:44] Using config file ▇▇▇▇▇▇/deploy-config.js
[21:43:44] Using gulpfile ▇▇▇▇▇▇/webpack-deploy/gulpfile.js
[21:43:44] Starting 'deploy-s3'...
[21:43:44] Finished 'deploy-s3' after 38 ms
[21:43:44] Using config file ▇▇▇▇▇▇/deploy-config.js
[21:43:45] Using gulpfile ▇▇▇▇▇▇/node_modules/webpack-deploy/gulpfile.js
[21:43:45] Starting 'rollbar-source-map'...
[21:43:45] 'rollbar-source-map' errored after 320 μs
[21:43:45] TypeError: Cannot read property 'files' of undefined
    at uploadAppVersions (▇▇▇▇▇▇/node_modules/webpack-deploy/tasks/rollbar-source-map.js:72:23)
    at ▇▇▇▇▇▇/node_modules/webpack-deploy/tasks/rollbar-source-map.js:175:5
    at module.exports.getRevision (▇▇▇▇▇▇/node_modules/webpack-deploy/tasks/utils.js:39:69)
    at Gulp.<anonymous> (/▇▇▇▇▇▇/node_modules/webpack-deploy/tasks/rollbar-source-map.js:174:3)
    at module.exports (/Users/marek/Developer/pro-next/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (▇▇▇▇▇▇node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (▇▇▇▇▇▇/node_modules/orchestrator/index.js:214:10)
    at Gulp.Orchestrator.start (▇▇▇▇▇▇/node_modules/orchestrator/index.js:134:8)
    at ▇▇▇▇▇▇/node_modules/gulp/bin/gulp.js:129:20
    at _combinedTickCallback (internal/process/next_tick.js:67:7)

I'm using node 6.9.4 & webpack 1.12.15 but I don't think this is version specific.
build.log was generated by $ webpack >> build.log. App written in elm-lang (using webpack-elm).

I didn't dig deeper into issue yet - Do you think it will be easy patch or bigger story?

Thanks for publishing this package anyway! 🚀

[LeZuse]

@turboMaCk Thanks for reporting the issue! The thing is that the default deploy command basically utilizes all the available subcommands without much configuration (yet; feel free to send a PR).

Individual subcommands each have their specific section in the config but there is no option to simply just turn anyone of them off (deploy just blindly calls all the subcommands one by one).

Nevertheless, I agree that the command should be defensive enough and should provide guidance for any misconfiguration instead of a cryptic error or just simply skip the relevant procedure.

A possible workaround for you is to provide an empty rollbar: {} config section or forking and modifying the main deploy script so that it does not call the rollbar subcommand.

[turboMaCk]

Thanks for blazingly fast response!

I just reverse engineered it a bit and came to some conclusion. Adding:

    rollbar: {
        staging: {}
    },
    slack: {
        staging: {}
    },
    git: {
        staging: {}
    }

doesn't prevent all errors but at least it seems like all tasks are executed after doing that. Nevertheless I still need to setup some other things before I'll be able to test deploy end-to-end. I can't promise anything right now since I'm just doing a bit of exploration in my free time but if we decide to use this plugin I'll be more than happy to contribute back all.

Thanks for your time and good luck with all your projects!

[LeZuse]

@turboMaCk FYI, just found out there is a fork that makes rollbar and slack defensive: hyperoslo@ab52e01