Source code links in Reference page no longer work

[JetStarBlues]

Most appropriate sub-area of p5.js?

• Other (documentation)

Details about the bug:

At the bottom of a Reference page entry, there is a link that points to the code associated with a function.

With the new release 1.4.0, these links no longer work.

The urls seem to point to https://github.com/processing/p5.js/blob/1.4.0/src/...
However the tag in the repo is named v1.4.0 not 1.4.0.
Previous releases have both a v prefixed tag, and one without. Which is likely why the links worked before.

[limzykenneth]

@outofambit Was the release steps run as npm run release? What I think is the problem here is that the git tag generated by npm version (ie. the versions without the "v" prefix) is either not generated (npm version was not run as part of npm run release or otherwise) or the generated git tag is not pushed to remote here. npm run release should have taken care of these already. Or maybe it's the other way round, only the npm generated git tag was pushed while the release tag (without "v" prefix was not created).

Can you check locally on the machine you created the release whether the git tag exist or not?

It seems I was mistaken, the npm version generated git tag is probably the one with the "v" prefix, which probably means the git tags without the prefix was created manually before? If that's the case we can probably modify the link the documentation footer points to instead so we don't have to manually create a tag on new releases.

[outofambit]

@allcontributors add @jiwonMe for code

[allcontributors]

@outofambit

I've put up a pull request to add @jiwonMe! 🎉

[outofambit]

fixed with https://github.com/processing/p5.js-website/pull/1051