From 00c48dd049900ad9940205dcf1ebf2a5b8a2b73e Mon Sep 17 00:00:00 2001 From: A M Chung Date: Tue, 14 Sep 2021 16:19:38 -0700 Subject: [PATCH 1/4] updated browser_error texts and millis unit tests --- src/core/friendly_errors/browser_errors.js | 4 ++-- test/unit/utilities/time_date.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/core/friendly_errors/browser_errors.js b/src/core/friendly_errors/browser_errors.js index 6abdc4a4b3..76a2be77a2 100644 --- a/src/core/friendly_errors/browser_errors.js +++ b/src/core/friendly_errors/browser_errors.js @@ -91,7 +91,7 @@ const strings = { browser: 'all' }, { - msg: "Cannot read property '{{.}}' of null", + msg: 'Cannot read property of null', type: 'READNULL', browser: 'Chrome' }, @@ -101,7 +101,7 @@ const strings = { browser: 'Firefox' }, { - msg: "Cannot read property '{{.}}' of undefined", + msg: 'Cannot read property of undefined', type: 'READUDEFINED', browser: 'Chrome' }, diff --git a/test/unit/utilities/time_date.js b/test/unit/utilities/time_date.js index 4ded1b7afe..df95c29847 100644 --- a/test/unit/utilities/time_date.js +++ b/test/unit/utilities/time_date.js @@ -110,7 +110,7 @@ suite('time and date', function() { var runningTime = 50; var init_date = window.performance.now(); // wait :\ - while (window.performance.now() - init_date < runningTime) { + while (window.performance.now() - init_date <= runningTime) { /* no-op */ } assert.operator(myp5.millis(), '>', runningTime, 'everything is ok'); @@ -121,7 +121,7 @@ suite('time and date', function() { var init_date = Date.now(); var result = myp5.millis(); // wait :\ - while (Date.now() - init_date < runningTime) { + while (Date.now() - init_date <= runningTime) { /* no-op */ } var newResult = myp5.millis(); From 126e59aff28f2ae4aab26b36ea734545520d2957 Mon Sep 17 00:00:00 2001 From: A M Chung Date: Tue, 14 Sep 2021 16:54:54 -0700 Subject: [PATCH 2/4] fixing typos --- src/core/friendly_errors/browser_errors.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/friendly_errors/browser_errors.js b/src/core/friendly_errors/browser_errors.js index 76a2be77a2..f1fd655da7 100644 --- a/src/core/friendly_errors/browser_errors.js +++ b/src/core/friendly_errors/browser_errors.js @@ -91,7 +91,7 @@ const strings = { browser: 'all' }, { - msg: 'Cannot read property of null', + msg: 'Cannot read properties of null', type: 'READNULL', browser: 'Chrome' }, @@ -101,7 +101,7 @@ const strings = { browser: 'Firefox' }, { - msg: 'Cannot read property of undefined', + msg: 'Cannot read properties of undefined', type: 'READUDEFINED', browser: 'Chrome' }, From e8c9a6d2e8e340178c13a1f766e58a5514630308 Mon Sep 17 00:00:00 2001 From: A M Chung Date: Tue, 14 Sep 2021 17:07:49 -0700 Subject: [PATCH 3/4] more generalized chrome error message --- src/core/friendly_errors/browser_errors.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/friendly_errors/browser_errors.js b/src/core/friendly_errors/browser_errors.js index f1fd655da7..0e8b70dacb 100644 --- a/src/core/friendly_errors/browser_errors.js +++ b/src/core/friendly_errors/browser_errors.js @@ -91,7 +91,7 @@ const strings = { browser: 'all' }, { - msg: 'Cannot read properties of null', + msg: 'Cannot read {{.}} of null', type: 'READNULL', browser: 'Chrome' }, @@ -101,7 +101,7 @@ const strings = { browser: 'Firefox' }, { - msg: 'Cannot read properties of undefined', + msg: 'Cannot read {{.}} undefined', type: 'READUDEFINED', browser: 'Chrome' }, From 49d6b337b6c8f921d08ca9fc3e053a00cf1e4b45 Mon Sep 17 00:00:00 2001 From: A M Chung Date: Tue, 14 Sep 2021 18:21:41 -0700 Subject: [PATCH 4/4] minor edit for consistency --- src/core/friendly_errors/browser_errors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/friendly_errors/browser_errors.js b/src/core/friendly_errors/browser_errors.js index 0e8b70dacb..1ab7784e4e 100644 --- a/src/core/friendly_errors/browser_errors.js +++ b/src/core/friendly_errors/browser_errors.js @@ -91,7 +91,7 @@ const strings = { browser: 'all' }, { - msg: 'Cannot read {{.}} of null', + msg: 'Cannot read {{.}} null', type: 'READNULL', browser: 'Chrome' },