Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SliceZone): restore resolver prop #181

Merged
merged 1 commit into from
May 9, 2023

Conversation

angeloashmore
Copy link
Member

Types of changes

  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR restores the resolver prop in <SliceZone>.

This prop is deprecated and should not be used. It will be removed in the next major version. It was mistakenly removed in a minor release (v2.6.0).

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #181 (a2c2768) into master (8f30e6c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           master     #181    +/-   ##
========================================
  Coverage   99.44%   99.44%            
========================================
  Files          20       21     +1     
  Lines        2332     2531   +199     
  Branches      126      129     +3     
========================================
+ Hits         2319     2517   +198     
- Misses         13       14     +1     
Impacted Files Coverage Δ
src/SliceZone.tsx 99.08% <100.00%> (+0.51%) ⬆️
src/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link

github-actions bot commented May 9, 2023

size-limit report 📦

Path Size
./dist/index.cjs 7.08 KB (+1.55% 🔺)
./dist/index.js 4.66 KB (+1.6% 🔺)
./dist/react-server.cjs 6.27 KB (+1.81% 🔺)
./dist/react-server.js 4.22 KB (+1.99% 🔺)

@angeloashmore angeloashmore merged commit e3604d9 into master May 9, 2023
@angeloashmore angeloashmore deleted the aa/restore-slicezone-resolver branch May 9, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants