From 82cbf449a08674b0e0866c79524a528c9de52a1c Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Wed, 11 Sep 2024 18:42:18 +0000 Subject: [PATCH 1/2] Moving Heading component to ga flag --- e2e/components/Heading.test.ts | 4 ++-- packages/react/src/Heading/Heading.tsx | 2 +- packages/react/src/Heading/__tests__/Heading.test.tsx | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/e2e/components/Heading.test.ts b/e2e/components/Heading.test.ts index 6be68f86195..6d62e3c7241 100644 --- a/e2e/components/Heading.test.ts +++ b/e2e/components/Heading.test.ts @@ -28,7 +28,7 @@ test.describe('Heading', () => { id: story.id, globals: { featureFlags: { - primer_react_css_modules_staff: true, + primer_react_css_modules_ga: true, }, }, }) @@ -51,7 +51,7 @@ test.describe('Heading', () => { id: story.id, globals: { featureFlags: { - primer_react_css_modules_staff: true, + primer_react_css_modules_ga: true, }, }, }) diff --git a/packages/react/src/Heading/Heading.tsx b/packages/react/src/Heading/Heading.tsx index 45e1fc4160d..e27329ef14c 100644 --- a/packages/react/src/Heading/Heading.tsx +++ b/packages/react/src/Heading/Heading.tsx @@ -37,7 +37,7 @@ const StyledHeading = styled.h2` ` const Heading = forwardRef(({as: Component = 'h2', className, variant, ...props}, forwardedRef) => { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') const innerRef = React.useRef(null) useRefObjectAsForwardedRef(forwardedRef, innerRef) diff --git a/packages/react/src/Heading/__tests__/Heading.test.tsx b/packages/react/src/Heading/__tests__/Heading.test.tsx index 83b6647fe4b..cc9998a9f30 100644 --- a/packages/react/src/Heading/__tests__/Heading.test.tsx +++ b/packages/react/src/Heading/__tests__/Heading.test.tsx @@ -142,12 +142,12 @@ describe('Heading', () => { ).toHaveStyleRule('font-style', 'italic') }) - describe('with primer_react_css_modules_staff enabled', () => { + describe('with primer_react_css_modules_ga enabled', () => { it('should only include css modules class', () => { HTMLRender( test @@ -163,7 +163,7 @@ describe('Heading', () => { const {container} = HTMLRender( test @@ -176,7 +176,7 @@ describe('Heading', () => { HTMLRender( Date: Mon, 16 Sep 2024 12:17:10 -0700 Subject: [PATCH 2/2] Create nice-moles-know.md --- .changeset/nice-moles-know.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nice-moles-know.md diff --git a/.changeset/nice-moles-know.md b/.changeset/nice-moles-know.md new file mode 100644 index 00000000000..873cf8be23c --- /dev/null +++ b/.changeset/nice-moles-know.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Changed Heading feature flag from `primer_react_css_modules_staff` to `primer_react_css_modules_ga`