From e1941a6455cff6a23ec28760c95dc95dbc160394 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Fri, 28 Jun 2019 09:57:37 -0700 Subject: [PATCH 1/4] Fix typo in Link so it applies button styles --- src/Link.js | 2 +- src/__tests__/Link.js | 4 +++ src/__tests__/__snapshots__/Link.js.snap | 32 ++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/src/Link.js b/src/Link.js index c086914faec..dc030fe652a 100644 --- a/src/Link.js +++ b/src/Link.js @@ -29,7 +29,7 @@ const Link = styled.a` text-decoration: underline; ${hoverColor}; } - ${props => (props.is === 'button' ? buttonStyles : '')}; + ${props => (props.as === 'button' ? buttonStyles : '')}; ${TYPOGRAPHY} ${COMMON}; ` diff --git a/src/__tests__/Link.js b/src/__tests__/Link.js index fe88b342b40..f247e681bd2 100644 --- a/src/__tests__/Link.js +++ b/src/__tests__/Link.js @@ -34,4 +34,8 @@ describe('Link', () => { expect(render()).toHaveStyleRule('font-style', 'italic') expect(render()).toHaveStyleRule('font-style', 'normal') }) + + it('applies button styles when rendering a button element', () => { + expect(render()).toMatchSnapshot() + }) }) diff --git a/src/__tests__/__snapshots__/Link.js.snap b/src/__tests__/__snapshots__/Link.js.snap index 642911e0b2a..db6af044eae 100644 --- a/src/__tests__/__snapshots__/Link.js.snap +++ b/src/__tests__/__snapshots__/Link.js.snap @@ -1,5 +1,37 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP +exports[`Link applies button styles when rendering a button element 1`] = ` +.c0 { + -webkit-text-decoration: none; + text-decoration: none; + display: inline-block; + padding: 0; + font-size: inherit; + white-space: nowrap; + cursor: pointer; + -webkit-user-select: none; + -moz-user-select: none; + -ms-user-select: none; + user-select: none; + background-color: transparent; + border: 0; + -webkit-appearance: none; + -moz-appearance: none; + appearance: none; + color: #0366d6; +} + +.c0:hover { + -webkit-text-decoration: underline; + text-decoration: underline; +} + +