Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Block component to be called Box again #189

Closed
4 tasks done
broccolini opened this issue Aug 6, 2018 · 3 comments
Closed
4 tasks done

Update Block component to be called Box again #189

broccolini opened this issue Aug 6, 2018 · 3 comments
Assignees

Comments

@broccolini
Copy link
Member

broccolini commented Aug 6, 2018

To do:

  • rename Box to BorderBox
  • rename Block to Box
  • update all the places Box is currently used
  • update all the places Block is currently used
@shawnbot

This comment has been minimized.

@shawnbot
Copy link
Contributor

shawnbot commented Aug 7, 2018

Serious question: Are we planning on porting Box from Primer CSS? Because we use it a lot, both in the product and in our own docs. It seems kinda crazy to replace every instance of <Box> with:

<Block bg="white" border={1} borderColor="gray.2" borderRadius={1}>

This was referenced Aug 8, 2018
@shawnbot
Copy link
Contributor

shawnbot commented Aug 8, 2018

FYI, I updated the todos in this after our discussion in Slack about Box being renamed BorderBox.

@shawnbot shawnbot assigned shawnbot and emplums and unassigned shawnbot Aug 13, 2018
@emplums emplums closed this as completed Aug 14, 2018
@emplums emplums mentioned this issue Aug 14, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants