Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable error when filters become available dynamically #2478

Closed
VsevolodGolovanov opened this issue Nov 29, 2021 · 2 comments
Closed

DataTable error when filters become available dynamically #2478

VsevolodGolovanov opened this issue Nov 29, 2021 · 2 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@VsevolodGolovanov
Copy link

VsevolodGolovanov commented Nov 29, 2021

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/datatable-with-nicefilter-dynamic-10zxy

Current behavior
Have a table where filters are available dynamically: they can become visible or hidden during the DataTable's lifetime.
When filters should become visible an error is thrown instead: TypeError model is undefined (Firefox) or TypeError Cannot read properties of undefined (reading 'value') (Chrome).

Expected behavior
Filters should render successfully.

Minimal reproduction of the problem with instructions
Open the linked codesandbox. Wait 2 sec for the effect simulating data loading to trigger. This effect sets filter visibility to true, resulting in the error.

Please tell us about your environment:

  • React version:

  • PrimeReact version:
    7.0.1

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    Firefox, Chrome.

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

@VsevolodGolovanov
Copy link
Author

This worked in 6.5.0.

@VsevolodGolovanov
Copy link
Author

I left NiceTableFilter there in case anything else comes up. It's just a MultiSelect filter that allows picking from the values in the corresponding column data.

@mertsincan mertsincan self-assigned this Dec 13, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Dec 13, 2021
@mertsincan mertsincan added this to the 8.0.0 milestone Dec 13, 2021
@mertsincan mertsincan modified the milestones: 8.0.0, 7.1.0 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants