Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable - Impossible to implement Expandable Row Groups with Row Expansion #2213

Closed
sergeykimaia opened this issue Jul 22, 2021 · 4 comments · Fixed by #4192
Closed

DataTable - Impossible to implement Expandable Row Groups with Row Expansion #2213

sergeykimaia opened this issue Jul 22, 2021 · 4 comments · Fixed by #4192
Assignees
@anatoly314
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
9.4.0

Comments

@sergeykimaia
Copy link

sergeykimaia commented Jul 22, 2021 •
edited by melloware
Loading

There's already a closed issue about this topic: ##1510

it was closed due to a misunderstanding, right now the DataTable component is relying on the prop "expandedRows"
which does not distinguish between Expanded Group Rows and Expanded Rows

TLDR: cant implement https://primefaces.org/primereact/showcase/#/datatable/rowexpand with https://primefaces.org/primereact/showcase/#/datatable/rowgroup (expandable)
@sergeykimaia sergeykimaia changed the title Impossible to implement Expandable Row Groups with Row Expansion DataTable - Impossible to implement Expandable Row Groups with Row Expansion Jul 23, 2021
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 8, 2021
@melloware
Copy link
Member

Closing. Will reopen if a code sandbox reproducer is provided

@melloware melloware added Resolution: Needs More Information More information about the issue is needed to find a correct solution and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 18, 2022
@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2022
@anatoly314
Copy link
Contributor

@melloware , this is code sandbox of the issue: https://stackblitz.com/edit/react-fusf42?file=src%2Fdemo.js, expandable rows don't work, if you remove groupRowsBy="category" it will work. Can't achieve that expandable rows will work together with groupRowsBy.
Thank you for your help.

@melloware melloware reopened this Mar 27, 2023
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Resolution: Needs More Information More information about the issue is needed to find a correct solution labels Mar 27, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 27, 2023
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 27, 2023
@anatoly314 anatoly314 mentioned this issue Mar 28, 2023
Merged
@anatoly314
Copy link
Contributor

I've created PR for this issue, hope it will be merged.

@melloware melloware added this to the 9.2.3 milestone Mar 28, 2023
@melloware
Copy link
Member

@anatoly314 I assigned PrimeTek to review. Thanks for the PR!

@mertsincan mertsincan modified the milestones: 9.3.1, 9.4.0 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatoly314 anatoly314

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
9.4.0
4 participants
@anatoly314 @melloware @mertsincan @sergeykimaia