Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectButton: getOptionValue is called twice in onItemClick if multiple is false (single mode) #13553

Closed
Kisters-BS opened this issue Aug 28, 2023 · 0 comments · Fixed by #13010
Closed

SelectButton: getOptionValue is called twice in onItemClick if multiple is false (single mode) #13553

Kisters-BS opened this issue Aug 28, 2023 · 0 comments · Fixed by #13010
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
16.3.0

Comments

@Kisters-BS
Copy link
Contributor

Describe the bug

getOptionValue is called twice in onItemClick if multiple is false (single mode)

Environment

https://github.com/primefaces/primeng/blob/master/src/app/components/selectbutton/selectbutton.ts#L170

Reproducer

No response

Angular version

16.0.0

PrimeNG version

16.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.19.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

getOptionValue is called once
@Kisters-BS Kisters-BS added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 28, 2023
@Kisters-BS Kisters-BS mentioned this issue Aug 28, 2023
Merged
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 29, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
16.3.0
Development

Successfully merging a pull request may close this issue.

Modify refactor selectButton Kisters-BS/primeng
2 participants
@mertsincan @Kisters-BS