Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table | add showButtons input to inputNumber in ColumnFilter #11881

Closed
Plankton93 opened this issue Aug 30, 2022 · 0 comments
Closed

Table | add showButtons input to inputNumber in ColumnFilter #11881

Plankton93 opened this issue Aug 30, 2022 · 0 comments
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@Plankton93
Copy link

Plankton93 commented Aug 30, 2022

Describe the feature you would like to see added

I would like to handle the [showButtons] attribute of the inputNumber (columnFilter).

According to current code you are setting the [showButtons] attribute always on true.

<p-inputNumber *ngSwitchCase="'numeric'" [ngModel]="filterConstraint?.value" (ngModelChange)="onModelChange($event)" (onKeyDown)="onNumericInputKeyDown($event)" [showButtons]="true" [minFractionDigits]="minFractionDigits" [maxFractionDigits]="maxFractionDigits" [prefix]="prefix" [suffix]="suffix" [placeholder]="placeholder" [mode]="currency ? 'currency' : 'decimal'" [locale]="locale" [localeMatcher]="localeMatcher" [currency]="currency" [currencyDisplay]="currencyDisplay" [useGrouping]="useGrouping"></p-inputNumber>

I don't want to see them so i want to handle this attribute.

Is your feature request related to a problem?

I am not able to control the [showButtons] attribute of columnFilter - inputNumber element.

Describe the solution you'd like

Instead of default [showButtons]="true" binding, there should be an Input() which controls this attribute.

@Input() showButtons: boolean
[showButtons]="showButtons"
<p-columnFilter *ngIf="header.filterType === NUMERIC" [type]="NUMERIC" [field]="header.filterField" [useGrouping]="false" [showButtons]="false" [showMenu]="false"> </p-columnFilter>

Describe alternatives you have considered

No response

Additional context

It would be nice, if this would be a feature for older versions to like up to 10? 12?

@Plankton93 Plankton93 added the Type: New Feature Issue contains a new feature or new component request label Aug 30, 2022
@Plankton93 Plankton93 changed the title Component: Table - Column Filter -> inputNumber -> showButtons handleable Component: Table - Column Filter -> inputNumber -> showButtons controlable Aug 30, 2022
@cetincakiroglu cetincakiroglu added this to the 14.0.3 milestone Sep 1, 2022
@cetincakiroglu cetincakiroglu changed the title Component: Table - Column Filter -> inputNumber -> showButtons controlable Table | add showButtons input to inputNumber in ColumnFilter Sep 7, 2022
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: New Feature Issue contains a new feature or new component request labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants