Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button | loadingIcon is not displayed when icon is not provided #10822

Closed
Urtgard opened this issue Nov 7, 2021 · 0 comments
Closed

Button | loadingIcon is not displayed when icon is not provided #10822

Urtgard opened this issue Nov 7, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Urtgard
Copy link
Contributor

Urtgard commented Nov 7, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

https://stackblitz.com/edit/primeng-button-demo-ysmtsh?file=src%2Fapp%2Fapp.component.html

Current behavior
loadingIcon is not displayed when icon attribute is not provided and button element is used.

Expected behavior
loadingIcon should be displayed even if no icon is set.

Minimal reproduction of the problem with instructions

<button pButton label="Search" [loading]="true"></button>
<button pButton label="Search" icon=" " [loading]="true"></button>
<p-button label="Search" [loading]="true"></p-button>

image

@Urtgard Urtgard changed the title Button | loadingIcon is not displayed when icon is empty Button | loadingIcon is not displayed when icon is not provided Nov 7, 2021
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 8, 2021
@yigitfindikli yigitfindikli added this to the 13.0.0-rc.2 milestone Nov 8, 2021
@yigitfindikli yigitfindikli self-assigned this Nov 8, 2021
@yigitfindikli yigitfindikli modified the milestones: 13.0.0-rc.2, 13.0.0-rc.1 Nov 8, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants