Add a filter panel #196
Add a filter panel #196
Conversation
|
Problems:
|
|
Problems:
|
| import tornadofx.launch | ||
|
|
||
| class SolveApp : App(MainView::class) { | ||
| class SolveApp : App(MainView::class, ApplicationStylesheet::class) { |
There was a problem hiding this comment.
We already have global application style class Style.kt, can we merge them?
| const val IconsLayersFilled = "/icons/sidepanel/LayersFilled.png" | ||
| const val IconsGrid = "/icons/sidepanel/Grid.png" | ||
| const val IconsGridSelected = "/icons/sidepanel/GridSelected.png" |
There was a problem hiding this comment.
Create an issue to convert all icons to svg
| return null | ||
| } | ||
|
|
||
| return constraints.first().message |
There was a problem hiding this comment.
When we adding a constraint for a message, it becomes a first element
| rippleGenerator.clipSupplier = Supplier { | ||
| RippleClipTypeFactory(RippleClipType.CIRCLE).setRadius(radius).build(this) | ||
| } | ||
| style { |
There was a problem hiding this comment.
May be to global stylesheet?
There was a problem hiding this comment.
I think it's better to leave it inside, because we have a radius parameter passed as an argument, which is needed for both the button and the ripple factory when button is pressed. It also ensures that no other set of styles will change the settings of the button created in this function.
| attachTo(this@controlButton, op) | ||
| } | ||
|
|
||
| fun EventTarget.dialogHeaderLabel(text: String, op: Label.() -> Unit = {}) = label(text) { |
There was a problem hiding this comment.
Use it also in ChooserDialog
| paddingRight = 20.5 | ||
| } | ||
| ) | ||
| Platform.runLater { |
There was a problem hiding this comment.
Are you sure, that it will work always?
| } | ||
| ) | ||
| Platform.runLater { | ||
| val cellCheckbox = (cell.getChildList()?.firstOrNull { it is CheckBox } as? CheckBox) ?: return@runLater |
There was a problem hiding this comment.
May be singleOrNull?
| // Needed because when an unselected element is removed, | ||
| // the whole selection is recreated with the addition of the remaining elements, | ||
| // which value changes causes changes of selectionProperty. |
There was a problem hiding this comment.
Did not understand at all :(
| import solve.filters.settings.model.UIDFilterSetting | ||
| import solve.project.model.ProjectFrame | ||
|
|
||
| class Filter(val settings: List<FilterSetting<out Any>>) { |
There was a problem hiding this comment.
May be make it mutable to avoid problems with list view?
| projectController.model.projectProperty.onChange { | ||
| applyFilters() |
There was a problem hiding this comment.
Is there any case when a lot of updates happen at once?
This is a problem with the materialfx library, I tried to avoid this behavior for a long time, but nothing helped. |
Close #42, close #43, close #181
