-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opinion on converting the addon to ES6/Typescript? #227
Comments
I'd defer to @trek, fine by me but I haven't worked on the source. Fwiw I want to do something like this in Mirage soonish too. |
Some work has been done:
|
I've opened:
|
Since v3.0.1 native ES6 classes are distributed. I think this issue can be closed now. |
It is distributed as ES module, but I think @cibernox also mentioned pretender source should also be written in TS/es6+ |
I'd like to update pretender to work with fetch but as it is right now the codebase feels a messy (read: I'm so used to ES6 I can't even read
Pretender.prototype.
anymore).I'm thinking that a good plan could be to add a build that compiles the sourcecode with babel (perhaps even TS). That would also make easier to accomplish any refactor with certain guarantees.
Would you favor a re-write in ES6 or TS (+ drop Phantomjs?)
The text was updated successfully, but these errors were encountered: