Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed migrations #121

Closed
eaglemoor opened this issue Oct 31, 2018 · 4 comments
Closed

Missed migrations #121

eaglemoor opened this issue Oct 31, 2018 · 4 comments

Comments

@eaglemoor
Copy link

Hi. We have 11 migration and 2 developers create migration not sequence. We have 1-11, 17 and 22. Then we try apply, goose apply 22 and skip 17.
image
@VojtechVitek
Copy link
Collaborator

What is goose output on this? Does it error out?

Can you elaborate further please?

@VojtechVitek
Copy link
Collaborator

Right, I think I know what happened.. goose is ignoring anything that is not applied and has a smaller version.

@1vn we gotta error out in this case.

And I think we should remove is_applied column, I think it's useless (correct me if I'm wrong)

We might even release goose v4.

@eaglemoor
Copy link
Author

No error =(

@VojtechVitek
Copy link
Collaborator

Alright, so in this case goose up should error out.

Looks like migration 22 was merged in & applied before 17. And then, when running goose up against 17, goose silently ignored the version, even though it should have error out, forcing the dev to rename the migration or run goose fix (see #120).

@mfridman mfridman mentioned this issue Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VojtechVitek @eaglemoor