Incorrect behavior of timing selection

[iSaturnx]

Type

Game behaviour

Bug description

After the latest update, the behavior of preserving the timing selection has changed to selecting the current timing point that specifically has 'Timing' enabled when switching in and out of the timing tab, rather than (how it was before and expected) keeping the selection of the current timing point after (without 'Timing' enabled).

Screenshots or videos

Screen.Recording.2025-01-24.at.1.10.59.AM.mov

Version

2025.118.2

Logs

compressed-logs.zip

[bdach]

The reasoning for always choosing a group with a timing point was #22575. Before #31454 that logic would only fire on the very first enter of timing screen, but now it fires every time (it's not so much that previously it was "keeping the selection of the current timing point after", it just didn't change selection at all, so it was just kept as it was last time the screen was open).

@peppy any opinions how to proceed here? The fix is otherwise obvious (https://github.com/bdach/osu/compare/unify-selection-behaviour?expand=1), but the UX back-and-forth is making me question PRing that.

[peppy]

I'd probably apply the proposed PR and see how people react. Having the selection change each time a user enters the timing screen may be the actual issue though, and if that comes up as a regular point of concern then we'll probably just not want to do that.