Skip to content

Editor context menu persists after object is deleted #29132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kadambishreyas opened this issue Jul 27, 2024 · 2 comments · Fixed by #29279
Open

Editor context menu persists after object is deleted #29132

kadambishreyas opened this issue Jul 27, 2024 · 2 comments · Fixed by #29279

Comments

@kadambishreyas
Copy link
Contributor

kadambishreyas commented Jul 27, 2024

Type

Game behaviour

Bug description

was mapping on lazer. still haven't fixed muscle memory so i tend to right click (revealing the context menu) instead of deleting objects. when you do this, the context menu doesn't close, which seems unintentional as there is no reason to look at manipulation options for a removed object.

it's mildly frustrating because this turns a previously one-click operation (right click to delete) to a potentially three-click operation (misclick for menu, shift+click to delete object, left click to close menu) on missed input.

Screenshots or videos

Screen.Recording.2024-07-27.at.1.48.21.AM.mp4

Version

2024.727.0-lazer

Logs

compressed-logs.zip

@kadambishreyas
Copy link
Contributor Author

@normalid-awa @bdach
this issue is only partially fixed by the PR above. it does not handle the case where:

  • we are in the beatmap editor.
  • we place a slider (which seems to be strictly n>1 nodes in lazer).
  • we right click the slider, opening the slider's context menu.
  • with the menu open:
    • M3 click n-1 times on slider nodes.

observe that on the last (n-1st) click, the slider disappears but the context menu remains.
this seems to work on for all n>1, irrespective of the order of M3 clicking nodes, and regardless of whether we right-click the slider in the timeline or on the playfield.
this bug does NOT reproduce if we right-click to open the context menu of a slider node.

@bdach bdach reopened this Mar 17, 2025
@kadambishreyas
Copy link
Contributor Author

kadambishreyas commented Mar 19, 2025

sorry about the previous comment, i could not record a video when i first found it.
here's a repro video.

Screencast.2025-03-18.23.37.49.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants