osu://edit/ editor timestamp links with hit objects crash chat

[Susko3]

Type

Crash to desktop

Bug description

Editor timestamp link that are posted in full (osu://edit/xx:yy:zzz (u,v,...)) will throw unexpected exceptions when posted in chat.

First reported in https://discord.com/channels/188630481301012481/1097318920991559880/1179770517994078248.

Repro branch https://github.com/ppy/osu/compare/master...Susko3:fix-chat-editor-timestamps?expand=1, failing test commit: 8d02745

This commit adds the following test string which will generate two overlapping OpenEditorTimestamp links.

osu://edit/00:12:345 (1,2) - Test?
^------------------^		first OpenEditorTimestamp
           ^-------------^	second OpenEditorTimestamp

The overlapping links break the logic here: (this tries to add the text in between the links – text of negative length)

osu/osu.Game/Graphics/Containers/LinkFlowContainer.cs

Line 50 in 40dbf09

AddText(text[previousLinkEnd..link.Index]);

---

I'm not sure what's the expected outcome when the parser is given the string osu://edit/00:12:345 (1,2). Possible outcomes:

Parsed text with link	OpenEditorTimestamp argument	Notes
osu://edit/00:12:345 (1,2)	00:12:345 (1,2)	Makes the most sense, except spaces in the URL
osu://edit/00:12:345 (1,2)	00:12:345 (1,2)
osu://edit/00:12:345 (1,2)	00:12:345

Keep in mind that osu://edit/00:12:345%20(1,2) in chat only partially works, it'll move to the requested timestamp, but won't select any objects.

Screenshots or videos

The parsed links in the failing test:

Version

b2e1a63

Logs

2023-11-30 14:06:57 [error]: An unhandled error has occurred.
2023-11-30 14:06:57 [error]: System.ArgumentOutOfRangeException: Length cannot be less than zero. (Parameter 'length')
2023-11-30 14:06:57 [error]: at System.String.Substring(Int32 startIndex, Int32 length)
2023-11-30 14:06:57 [error]: at osu.Game.Graphics.Containers.LinkFlowContainer.AddLinks(String text, List`1 links) in C:\...\osu\osu.Game\Graphics\Containers\LinkFlowContainer.cs:line 50
2023-11-30 14:06:57 [error]: at osu.Game.Overlays.Chat.ChatLine.updateMessageContent() in C:\...\osu\osu.Game\Overlays\Chat\ChatLine.cs:line 215
2023-11-30 14:06:57 [error]: at osu.Game.Overlays.Chat.ChatLine.LoadComplete() in C:\...\osu\osu.Game\Overlays\Chat\ChatLine.cs:line 155
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Drawable.loadComplete()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Drawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Testing.TestBrowser.ErrorCatchingDelayedLoadWrapper.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
2023-11-30 14:06:57 [error]: at osu.Framework.Platform.GameHost.UpdateFrame()
2023-11-30 14:06:57 [error]: at osu.Framework.Threading.GameThread.processFrame()

[ppy-sentryintegration]

Sentry issue: OSU-TS2

[Loreos7]

For me the game is being crashed by posting timestamp link in chat:
network.log
runtime.log
performance.log
updater.log

[RatinFX]

It also happens when you type osu://xx:yy:zzz, it seems like advanced_link_regex adds it to the links at

osu/osu.Game/Online/Chat/MessageFormatter.cs

Line 271 in aa87e0a

handleAdvanced(advanced_link_regex, result, startIndex);

Unless it's used somewhere, I would expect the parser to just ignore anything osu:// when it was said in the in-game chat

[Susko3]

using osu:// urls in chat is tested, so I assume it's important

osu/osu.Game.Tests/Visual/Online/TestSceneChatLink.cs

Lines 92 to 94 in b2e1a63

	addMessageWithChecks($"Join my [#english]({OsuGameBase.OSU_PROTOCOL}chan/#english).", 1, expectedActions: LinkAction.OpenChannel);
	addMessageWithChecks($"Join my {OsuGameBase.OSU_PROTOCOL}chan/#english.", 1, expectedActions: LinkAction.OpenChannel);
	addMessageWithChecks($"Join my{OsuGameBase.OSU_PROTOCOL}chan/#english.", 1, expectedActions: LinkAction.OpenChannel);

[bdach]

I'm closing the issue as the crash is fixed. Supporting the other timestamp link syntax can be tracked separately.