Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculated classic style score is lower than standarised score. #23847

Closed
Akarinnnnn opened this issue Jun 9, 2023 · 16 comments
Closed

Calculated classic style score is lower than standarised score. #23847

Akarinnnnn opened this issue Jun 9, 2023 · 16 comments
Labels
missing details Can't move forward without more details from the reporter

Comments

@Akarinnnnn
Copy link

Type

Game behaviour

Bug description

Reproduce steps:

  1. Set "Gameplay/General/Score display mode" to "Classic".
  2. Play a map.
  3. Standardized score will show on score indicator and result page.

If you switch score display mode to "Standardised" and back now, the scores will display correctly again.

Screenshots or videos

osu_2023-06-09_20-44-48

Version

2023.605.0

Logs

runtime.log might be useful.

@bdach
Copy link
Collaborator

bdach commented Jun 9, 2023

I cannot reproduce this. Can you upload a video showing this?

@bdach bdach added the missing details Can't move forward without more details from the reporter label Jun 9, 2023
@Akarinnnnn
Copy link
Author

My score display mode is already "Classic" before startup. If you change it after startup, it will behave correct.
Here is reproduction video:

Untitled.mp4

@bdach
Copy link
Collaborator

bdach commented Jun 10, 2023

What the video above shows is #23782. As in, you played back a replay set using old score algorithm, which is incomparable to the new score algorithm (and old scores will not be recalculated).

If you can show this happening on a brand new score then I'll reopen and investigate again, but so far this looks like a duplicate/wontfix.

@bdach bdach closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2023
@Akarinnnnn
Copy link
Author

Akarinnnnn commented Jun 10, 2023

In previous video I selected an old score for convince. But same issue occurs to new score and gameplay. Here is the video shows a gameplay:

2023-06-10.17-03-35.mp4

In my investigation the most possible reason I think is that bindable from config.GetBindable<ScoreMode>(OsuSetting.ScoreDisplayMode) provided an default value, which is Standarised instead of Classic provided from config file.
Corrupted configuration database might also be the reason.

@bdach
Copy link
Collaborator

bdach commented Jun 10, 2023

The video above does not appear incorrect to me.

I assure you that I have attempted to reproduce this several times on short maps by playing them to completion (one example is https://osu.ppy.sh/beatmapsets/398977#osu/872885) and I have not managed to yet produce one instance wherein the score would have standardised score when classic mode is active.

@Akarinnnnn
Copy link
Author

In that video, if classic score display applied, score should absolutely above than 2000 after that amount of objects hit according to my experience. Therefore, the only reason that low score displayed is standardized score displayed.
Anyway, thank you for testing. I will try reset all settings to see if it can solved.

@bdach
Copy link
Collaborator

bdach commented Jun 10, 2023

Note that "classic scoring" is not, and never was, Score V1. It was only supposed to be a crude approximation of it, ultimately based on standardised score, the goal of which was to have a similar scaling progression and magnitude of total score as Score V1 did.

@Akarinnnnn
Copy link
Author

Sure. But it seems HUD displayed value is different from ScoreInfoExtensions.getDisplayScore. Is it excepted?

@bdach
Copy link
Collaborator

bdach commented Jun 10, 2023

If the HUD was wrong due to being in the wrong scoring mode, then I'd expect the results screen to show a different figure than the HUD does at the end of gameplay. I have not been able to reproduce that yet either.

Given that you seem to make various assertions about the code, then maybe you could try debugging it yourself, because I really see nothing wrong here.

@Akarinnnnn
Copy link
Author

The real reason which confuses me is the conversion algorithm gave a score which lower than standardized score.
The t/d/m in screenshot stands for total standardized score, display score and mode.
image

@bdach
Copy link
Collaborator

bdach commented Jun 18, 2023

I don't understand what I'm looking at there sorry. What is "total standardised score"? What is "display score"?

@Akarinnnnn
Copy link
Author

"Total standarised score" stands for real score which is standardised, and "display score" is the converted "classic" score which used by score indicator etc. Let's take a look at first line for example, you can see standarised score is 25906, which even larger than the score 23441 displayed on screen. This makes me wrongly think standarised score is displayed.

@bdach
Copy link
Collaborator

bdach commented Jun 18, 2023

Can you just post the code you used to produce the output above please.

@Akarinnnnn
Copy link
Author

I added an action breakpoint prints message above at osu\osu.Game\Screens\Play\HUD\GameplayScoreCounter.cs Line 51 (void updateDisplayScore() => Current.Value = scoreProcessor.GetDisplayScore(scoreDisplayMode.Value);), mapset is 六兆年と一夜物語- Rolniczy's Insane. I think print standarised score and calculated score in updateDisplayScore() is equalvent.

@Akarinnnnn Akarinnnnn changed the title Standardized score displayed while configuration set to Classic. Calculated classic style score is lower than standarised score. Jun 18, 2023
@bdach
Copy link
Collaborator

bdach commented Jun 18, 2023

"Classic" scoring is not a linear rescale of standardised. It starting with a lower value is expected. Once a certain performance threshold is crossed, the total score should increase above 1 million, however.

#23763 may be relevant here, though.

@Akarinnnnn
Copy link
Author

Yes, that is my problem facing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing details Can't move forward without more details from the reporter
Projects
None yet
Development

No branches or pull requests

2 participants