-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rank glitching when clearing for the first time and getting top 50 #23834
Comments
More info: |
More info:
I can't see a patern, and while most of the time it's a higher rank on the personal best, it's not always the case |
i believe it is an unrelated issue @y0rune. I'm talking about how a same game score can get you 2 different visual ranks. |
All right! I saw that "issue" in your screenshots so I thought I can be related. Thank you! |
@y0rune well, in your case you also have a serious issue that a lot of people are mentionning. It's a problem linked to the changing of the calculation of scores. It's called score V2. The problem is that old scores that used V1, have a higher score with less performances, making it hard or even impossible to beat those highscores. |
@Kiryonn so i can investigate further, could you please set a score on a fresh beatmap and leave it in the bad state rather than playing a second time? Can you also link the beatmap and attach a screenshot showing your personal best / leaderboard as above? I tested to make sure the sorting we're applying at our end is not having an adverse affect on this and it doesn't seem to be. Manual testing against a lot of beatmaps I had locally shows no assertion on this: diff --git a/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs b/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs
index 4c41ed3622..d8079145e8 100644
--- a/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs
+++ b/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs
@@ -6,6 +6,7 @@
using System.Diagnostics;
using System.Linq;
using System.Threading;
+using NUnit.Framework;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Game.Beatmaps;
@@ -160,6 +161,14 @@ private void load()
if (!newRequest.Equals(scoreRetrievalRequest))
return;
+ var originalScores = response.Scores.Select(s => s.ToScoreInfo(rulesets, fetchBeatmapInfo)).OrderByTotalScore().ToArray();
+ var sortedScores = originalScores.OrderByTotalScore().ToArray();
+
+ for (int i = 0; i < originalScores.Length; i++)
+ {
+ Debug.Assert(originalScores[i].OnlineID == sortedScores[i].OnlineID);
+ }
+
SetScores(
response.Scores.Select(s => s.ToScoreInfo(rulesets, fetchBeatmapInfo)).OrderByTotalScore(),
response.UserScore?.CreateScoreInfo(rulesets, fetchBeatmapInfo)
|
Pretty sure it's a front end issue. Also i couldn't reproduce the bug 100% of the time even tho the condtitions where the same somehow. Version2023.617.0-lazer Beatmaphttps://osu.ppy.sh/beatmapsets/899955#osu/1879805 ScreenshotLogdatabase.log |
Type
Game behaviour
Bug description
When clearing a song for the first time, the game will display a different
personnal best score rank
than theleaderboard rank
.lines of table:
As you can see it only happens when you enter the top50 from beating the song for the first time
Screenshots or videos
Version
2023.605.0-lazer
Logs
updater.log
database.log
input.log
network.log
performance.log
The text was updated successfully, but these errors were encountered: