Skip to content

Excluding map tags from search doesn't work #12084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Qunas101 opened this issue Apr 7, 2025 · 7 comments · May be fixed by #12131 or #12134
Open

Excluding map tags from search doesn't work #12084

Qunas101 opened this issue Apr 7, 2025 · 7 comments · May be fixed by #12131 or #12134
Assignees
Labels
area:search area:tags missing details priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@Qunas101
Copy link

Qunas101 commented Apr 7, 2025

Current behavior: putting -tag in search doesn't seem to affect the results in any way

Expected behavior: It should exclude all maps with tag from search

Example: https://osu.ppy.sh/beatmapsets?g=10&q=ranked%3D2023%20-electronic&s=ranked - same example as in #10916, only back then this prompt produced a few maps that weren't tagged with electronic by mapper. Now all maps with electronic are included

@Qunas101
Copy link
Author

Qunas101 commented Apr 17, 2025

It seems to only work if sorted by Relevance, and even then it's only a suggestion, it just pushes 'excluded' beatmaps to bottom

@peppy
Copy link
Member

peppy commented Apr 18, 2025

Bumping in priority since this is a primary use of tags / search.

@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Apr 18, 2025
@nanaya
Copy link
Collaborator

nanaya commented Apr 18, 2025

-thing seem to work though? The link above explicitly selected electronic genre but otherwise there's no electronic in the tag.

@nanaya
Copy link
Collaborator

nanaya commented Apr 18, 2025

I think more details is needed, preferably with screenshots and links on the query and the result

(I did cursory check and the result seems correct)

@Qunas101
Copy link
Author

I think more details is needed, preferably with screenshots and links on the query and the result

Sure, I am an idiot for not including it in my reply

https://osu.ppy.sh/beatmapsets?l=8&q=ranked%3D2020%20-viking&s=ranked

Look at this example. Notice how the map with viking gets pushed to the bottom of the list. You can repeat the same process with other tags from maps in the example. Since maps are not removed from search completely, the sorting gets overwritten if you sort by anything other than Relevance.

@nanaya
Copy link
Collaborator

nanaya commented Apr 18, 2025

So it's not "affect the results in any way" but more of it's still included just with lower relevancy (and thus not useful when sorted by anything else).

Apparently it's from adding the user tag query... removing the specific part hides it again

->should([
'nested' => [
'path' => 'beatmaps',
'query' => QueryHelper::queryString($this->params->queryString, ['beatmaps.top_tags'], 'or', 0.5 / count($terms)),
],
])

@Qunas101
Copy link
Author

Also, beatmap search overlay on lazer experiences completely the same problem, but I assumed it works on the same web voodoo? So I didn't report it there

@notbakaneko notbakaneko self-assigned this Apr 22, 2025
@notbakaneko notbakaneko linked a pull request Apr 22, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:search area:tags missing details priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
4 participants