From 323e4b139ffe2dd415e5cd86e6283a2abe72d559 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Thu, 25 Jul 2024 13:08:31 +0900 Subject: [PATCH 1/2] Fix failed scores getting included in playlist score distribution --- osu.Server.Spectator/Database/DatabaseAccess.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Server.Spectator/Database/DatabaseAccess.cs b/osu.Server.Spectator/Database/DatabaseAccess.cs index 8655f661..84861d6f 100644 --- a/osu.Server.Spectator/Database/DatabaseAccess.cs +++ b/osu.Server.Spectator/Database/DatabaseAccess.cs @@ -427,7 +427,7 @@ public async Task GetMultiplayerRoomStatsAsync(l long[] totalScores = (await connection.QueryAsync( "SELECT `scores`.`total_score` FROM `scores` " + "JOIN `multiplayer_score_links` ON `multiplayer_score_links`.`score_id` = `scores`.`id` " - + "WHERE `multiplayer_score_links`.`playlist_item_id` = @playlistItemId", new + + "WHERE passed = 1 AND `multiplayer_score_links`.`playlist_item_id` = @playlistItemId", new { playlistItemId = playlistItemIds[i] })).ToArray(); From 015d598256d224cf9463670ccf7223d1867bed2d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Thu, 25 Jul 2024 07:18:24 +0200 Subject: [PATCH 2/2] Quote column name for consistency Co-authored-by: Dan Balasescu --- osu.Server.Spectator/Database/DatabaseAccess.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Server.Spectator/Database/DatabaseAccess.cs b/osu.Server.Spectator/Database/DatabaseAccess.cs index 84861d6f..ab74fb60 100644 --- a/osu.Server.Spectator/Database/DatabaseAccess.cs +++ b/osu.Server.Spectator/Database/DatabaseAccess.cs @@ -427,7 +427,7 @@ public async Task GetMultiplayerRoomStatsAsync(l long[] totalScores = (await connection.QueryAsync( "SELECT `scores`.`total_score` FROM `scores` " + "JOIN `multiplayer_score_links` ON `multiplayer_score_links`.`score_id` = `scores`.`id` " - + "WHERE passed = 1 AND `multiplayer_score_links`.`playlist_item_id` = @playlistItemId", new + + "WHERE `passed` = 1 AND `multiplayer_score_links`.`playlist_item_id` = @playlistItemId", new { playlistItemId = playlistItemIds[i] })).ToArray();