Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platforms other than Windows crash when last windowed mode is borderless in latest master #6262

Closed
Joehuu opened this issue Apr 22, 2024 · 1 comment · Fixed by #6263
Closed

Comments

@Joehuu
Copy link
Member

Joehuu commented Apr 22, 2024

Using macOS, but looking at the method, Windows is only implemented.

If you were using borderless before the SDL3 merge, it crashes after updating to latest master and you would have to manually set to Windowed / Fullscreen.

[runtime] 2024-04-22 17:42:58 [error]: An unhandled error has occurred.
[runtime] 2024-04-22 17:42:58 [error]: System.PlatformNotSupportedException: Operation is not supported on this platform.
[runtime] 2024-04-22 17:42:58 [error]: at osu.Framework.Platform.SDL3Window.SetBorderless(Display display)
[runtime] 2024-04-22 17:42:58 [error]: at osu.Framework.Platform.SDL3Window.UpdateWindowStateAndSize(WindowState state, Display display, DisplayMode displayMode)
[runtime] 2024-04-22 17:42:58 [error]: at osu.Framework.Platform.SDL3DesktopWindow.UpdateWindowStateAndSize(Wi

The following osu!-side lines can probably be removed if borderless is not a thing anymore for macOS:
https://github.com/ppy/osu/blob/308744348f8d7919d38b5508bb904a27b9909fad/osu.Game/OsuGame.cs#L855-L863
https://github.com/ppy/osu/blob/308744348f8d7919d38b5508bb904a27b9909fad/osu.Game/Overlays/Settings/Sections/Graphics/LayoutSettings.cs#L271-L279

Fullscreen on macOS somewhat doesn't take full control on SDL3 anymore, but cmd-tab has a horrible delay as opposed to borderless.

@bdach
Copy link
Collaborator

bdach commented Apr 22, 2024

@Susko3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants