Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyke and fix tests #69

Closed
wants to merge 57 commits into from
Closed

Remove pyke and fix tests #69

wants to merge 57 commits into from

Conversation

pp-mo
Copy link
Owner

@pp-mo pp-mo commented Jun 15, 2021

🚀 Pull Request

A "lookahead" for complete removal of pyke, and fixing all the existing tests.

TODO:

This was referenced Jun 15, 2021
Merged
Closed
@pp-mo pp-mo force-pushed the replace_pyke_nopyke branch from 20a1e00 to 6c7a9da Compare June 22, 2021 12:28
@pp-mo pp-mo force-pushed the replace_pyke_nopyke branch 3 times, most recently from 8839f13 to 78447ed Compare June 23, 2021 15:34
bjlittle and others added 23 commits June 24, 2021 15:24
@bjlittle
optimise pre-commit (SciTools#4208)
9a06485
@bjlittle
convert docs print statements (SciTools#4209)
bfc6373
@pp-mo
Widen cube printout for long ancil or cell-measure names. (SciTools#4124
2e34c0d 
)

* Widen cube printout for long ancil or cell-measure names.

* Adjust result for fixed cube-units printout.
@github-actions @web-flow
Updated environment lockfiles (SciTools#4212)
b46b79c 
Co-authored-by: Lockfile bot <[email protected]>
@pp-mo
First steps in parallel rules implementation.
f427f85
@pp-mo
Rename some things + add comments.
1bb7338
@pp-mo
Headers, tweaks, reorg test__load_cube.
44bf952
@pp-mo
Fix handling of coord-systems.
5e3cb05
@pp-mo
Remove extra cdl.
dfa6074
@pp-mo
Add more grid-mapping tests; tidy testcode structure a bit.
1aa4676
@pp-mo
Test more grid types : rotated and some non-latlon (WIP).
87d3347
@pp-mo
Fix 'checker' call usage.
88a1b2d
@pp-mo
Reorganise testcode inheritance to provide testclasses for pyke/nonpy…
ad3ec2e 
…ke. Replace 'bad mapping' control with scale-factor key. **NOTE** non-pyke bad mercatorhas outstanding test failures -- to be fixed.
@pp-mo
Tests for all supported grid-mappings. Note which rules trigger in ea…
b58c4bc 
…ch case.
@pp-mo
Disable testing against non-pyke code, for now.
04b079a
@pp-mo
Revert old tests/test_netcdf.py
1e0833e
@pp-mo
Odd clarifying comments.
b119c7b
@pp-mo
Tidy testcase creation a bit.
364ea5b
@pp-mo
Tests for mapping-types mismatch between coords+grid-mapping; Test no…
4487961 
…nmonotonic dimcoord values; Test warnings (or not).
@pp-mo
Refactor to put different test areas in their own sourcefiles.
3f6e136
@pp-mo
Small fix to actions code.
fe8ee7e
@pp-mo
Move grid-mapping-specific content out of common load_cube__activate …
75550fc 
…code.
@pp-mo
Add tests for time rules.
97f2976
pp-mo added 20 commits June 29, 2021 10:36
@pp-mo
Add testing option to compare pyke and nonpyke loads.
e50cdd5
@pp-mo
Fixes to grid-mapping/dimcoord actions: passing all compare-tests.
2bfeff6
@pp-mo
Actions for remaining 'miscellaneous' behaviour: All tests passing, i…
72058b0 
…ncluding pyke == nonpyke checks.
@pp-mo
Improved comments in actions routines.
f8a1bbe
@pp-mo
Added actions for formulae (aka hybrid coords, factories).
6eaf756
@pp-mo
Tiny fix.
09df997
@pp-mo
Small review changes.
be9c0f1
@pp-mo
Added basic tests for Engine class.
0c5a5f6
@pp-mo
Raise actual warning for unrecognised formulae.
b55a925
@pp-mo
Remove unreachable warning code.
0da7ef3
@pp-mo
Remove unreachable rule-fail code.
4bba400
@pp-mo
Testcase for multiple hybrid coordinates.
eb46d51
@pp-mo
Fix rotated-aux-latitude test.
ce1e438
@pp-mo
Isort fixes.
2fdcdf9
@pp-mo
Remove pyke and simplify testing.
f985b0c
@pp-mo
Ensure a definite ordering for formula-root processing.
b0ac323
@pp-mo
Odd corrections to comments.
c26db97
@pp-mo
Updated all 'rules triggered' comments.
2f9d462
@pp-mo
Fix scope-bleed from actions test debugging, and turn it off.
c87fca8
@pp-mo
Updated lockfiles.
b40a446
@pp-mo pp-mo force-pushed the replace_pyke_nopyke branch from 97ca13a to b40a446 Compare June 29, 2021 10:02
@pp-mo pp-mo force-pushed the replace_pyke_nopyke branch from 0bad17c to 16be67b Compare July 1, 2021 11:46
@pp-mo pp-mo deleted the branch replace_pyke March 18, 2022 15:48
@pp-mo pp-mo closed this Mar 18, 2022
@pp-mo pp-mo deleted the replace_pyke_nopyke branch March 18, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pp-mo @bjlittle