Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw on trailing colons? #27

Closed
ben-eb opened this issue Jan 11, 2016 · 2 comments
Closed

Throw on trailing colons? #27

ben-eb opened this issue Jan 11, 2016 · 2 comments
Labels

Comments

@ben-eb
Copy link
Member

ben-eb commented Jan 11, 2016

Currently we do this, as it turns out it breaks support for Polymer mixins, see: https://github.com/ben-eb/gulp-cssnano/issues/17.

How should we handle these in future? Should we still throw or parse them as a type?

/cc @davidtheclark

@davidtheclark
Copy link
Contributor

parse them as a type

Does that mean --something: would have two type selectors, --something and :? Or that the whole thing would be one type selector?

The weird thing that I'm trying to get about the Polymer syntax is that it's mimicking custom properties -- so it's actually not intended to be a selector, I think, but a custom property -- but it doesn't look like they're applying it to :root. What I'm saying is I'm not sure that should be parsed as a selector.

If Polymer users put they're custom-property-mixin-declarations in :root rules, this would be a non-issue, right?

@ben-eb
Copy link
Member Author

ben-eb commented Jan 11, 2016

Not parsing these is much more acceptable, I think. I chose to ignore these "selectors" in postcss-minify-selectors so my use case is covered, but I wanted a second opinion. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants