-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event handlers of HTML through addEventListener
#62
Conversation
When you see the PR @thetutlage, could you create a test version for the meantime, please? To be able to run my app and test other features |
I was thinking to add the event handler functions within the script file directly. For example: The error stack event handlers can live here. https://github.com/poppinss/youch/blob/4.x/src/public/error_stack/script.js |
@thetutlage I agree with the suggested approach. I implemented the changes following this new approach :) |
Alright. That looks good. Thanks for the PR |
π Linked issue
closes #61
β Type of change
π Description
Add event handlers of HTML generated by Youch through
addEventListener
instead of using inline event handlersπ Checklist