-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context cancellation to backup routines #110
Comments
Hi @nilslice! Would you mind if I have crack at this? I want to trial |
Hey @eticzon - please do! Thank you & let me know if you have any questions. |
Hi @eticzon - checking in with you on the status of this in case you had made some progress or needed help? I'll hopefully have some time this weekend for issue clean-up and this PR is on my list to get done sooner than later. |
Hey @nilslice! Apologies for the delay. Yup, just familiarising myself with the overall project structure and all. I should be able to create a PR before the weekend. |
Awesome. I didn't mean any rush, just figured I'd ask and avoid duplicating efforts. Thank you! |
When backing up components of a Ponzu system via HTTP backup utility, we should provide a cancellation context so dropped connections will stop the backup. Some backups can be very expensive, especially the tar/gzip archiving of uploads.
ponzu/system/admin/handlers.go
Line 192 in 3a897e4
each
Backup
func will need to take thereq
with the context added with cancellation propagation.The text was updated successfully, but these errors were encountered: