From b27a7a34334b8a332c6af58849caa51835c5370b Mon Sep 17 00:00:00 2001
From: vargenau <vargenau@96ab9672-09ca-45d6-a79d-3d69d39ca109>
Date: Mon, 1 Mar 2021 13:47:42 +0000
Subject: [PATCH] Use class "error" when appropriate

---
 lib/plugin/UserPreferences.php | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/plugin/UserPreferences.php b/lib/plugin/UserPreferences.php
index 06fd99ce4..864ea51f8 100644
--- a/lib/plugin/UserPreferences.php
+++ b/lib/plugin/UserPreferences.php
@@ -78,6 +78,7 @@ function run($dbi, $argstr, &$request, $basepage)
         $args = $this->getArgs($argstr, $request);
         $user =& $request->_user;
         $user->_request = $request;
+        $iserror = false;
         if (defined('FUSIONFORGE') && FUSIONFORGE) {
             if (!($user->isAuthenticated())) {
                 return HTML::p(array('class' => 'error'),
@@ -129,6 +130,7 @@ function run($dbi, $argstr, &$request, $basepage)
                 } elseif ($rp = $request->getArg('pref')) {
                     // replace only changed prefs in $pref with those from request
                     if (!empty($rp['passwd']) and ($rp['passwd2'] != $rp['passwd'])) {
+                        $iserror = true;
                         $errmsg = _("Wrong password. Try again.");
                     } else {
                         if (empty($rp['passwd'])) unset($rp['passwd']);
@@ -148,9 +150,11 @@ function run($dbi, $argstr, &$request, $basepage)
                                 if ($passchanged) {
                                     $errmsg = _("Password updated.") . " ";
                                 } else {
+                                    $iserror = true;
                                     $errmsg = _("Password was not changed.") . " ";
                                 }
                             } else {
+                                $iserror = true;
                                 $errmsg = _("Password cannot be changed.");
                             }
                         }
@@ -167,7 +171,11 @@ function run($dbi, $argstr, &$request, $basepage)
                             }
                         }
                     }
-                    $args['errmsg'] = HTML::div(array('class' => 'feedback'), HTML::p($errmsg));
+                    if ($iserror) {
+                        $args['errmsg'] = HTML::div(array('class' => 'error'), HTML::p($errmsg));
+                    } else {
+                        $args['errmsg'] = HTML::div(array('class' => 'feedback'), HTML::p($errmsg));
+                    }
 
                 }
             }