Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit 404s for invalid tabs #2767

Closed
Swader opened this issue May 18, 2020 · 4 comments · Fixed by #2773
Closed

Emit 404s for invalid tabs #2767

Swader opened this issue May 18, 2020 · 4 comments · Fixed by #2773

Comments

@Swader
Copy link
Contributor

Swader commented May 18, 2020

In the wiki, we have links to some parts of the Apps UI. Those sometimes change, as is the case with https://polkadot.js.org/apps/#/staking/returns - would it be possible to get such non-existent URLs to return 404s? I know they're hash URLs so it's hard to do natively, but maybe a redirect to a 404 page if a URL doesn't result in a component being loaded?

@jacogr
Copy link
Member

jacogr commented May 18, 2020

When it cannot render something it should redirect to the default, i.e. explorer (or whatever is set as the default). However it is not on the top of the list, so atm it just renders the Unknown component.

@Swader
Copy link
Contributor Author

Swader commented May 20, 2020

I wanted 404 so our link-checker can detect it from CI of the wiki build, but it's just me being lazy

@jacogr
Copy link
Member

jacogr commented May 20, 2020

Not doing 404's, sorry. The aliasses should help with movements, should have done that ages ago.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants